@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
You can use the text-align property in CSS to align the text:
.QRBody p { text-align: center; }
-
To add multiple media queries to deal with various mobile screens, you can use the @media rule. This rule allows you to specify different styles for different media types/devices. e.g:
Note: This challenge does not need to use media queries.
@media only screen and (max-width: 30em) { /* Styles for devices with a maximum width of 30em = 480px */ } @media only screen and (max-width: 48em) { /* Styles for devices with a maximum width of 48em = 768px */ } @media only screen and (max-width: 64em) { /* Styles for devices with a maximum width of 64em = 1024px */ }
-
To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.
Using flex:
body { background-color: #d5e1ef; min-height: 100vh; display: flex; align-items: center; justify-content: center; }
Using grid:
body { background-color: #d5e1ef; min-height: 100vh; display: grid; place-content: center; }
Using flexbox and margin:
body { background-color: #d5e1ef; min-height: 100vh; display: flex; } .QRCodeContainer { margin: auto; }
HTML 📄:
- Always avoid skipping heading levels; Always start from
<h1>
, followed by<h2>
, and so on up to <h6> (<h1>,<h2>,...,<h6>).
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS 🎨:
-
You should use a CSS reset to remove the default browser styles and make your page look the same in all browsers.
Popular CSS resets:
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful