Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

QR code component with Bootstrap and Sass

sass/scss, bootstrap
Saleiux•230
@Saleiux
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jon Henrik Åvitsland•230
    @jonhenrikaavitsland
    Posted over 1 year ago

    Also if you want some resources on flex and grid for layout these did me well:

    https://css-tricks.com/snippets/css/a-guide-to-flexbox/ https://css-tricks.com/snippets/css/complete-guide-grid/#aa-introduction Also i think you should read up on box-sizing border-box: https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

    Good luck

    Marked as helpful
  • Jon Henrik Åvitsland•230
    @jonhenrikaavitsland
    Posted over 1 year ago

    Hi Saleiux, thanks for the follow. I follow you back ofc :)

    I know that you are learning to code, so am I, currently by school tho. But looking at your code, I want to mention some ideas that come to my mind and I hope it helps you improve on this design and furthermore when you work on new designs.

    I suppose that you are a free user, if you pay for the membership you do get design files that you can utilize to improve beyond just the visual picture, but you don't have to.

    I think that you forgot to declare the font family in your CSS file. You imported some font, but I can not see that it has been declared yet.

    Also, I see that you are using padding to position your elements within the card, perhaps could flex have been used to some extent :)

    You are using the rem unit size for width, I would rather use the rem unit size on font-sizes and a different unit on the width, and I think that in your case px is fine for width :)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub