QR code component with CSS Grid

Community feedback

• 

  Hassia Issah•50,410

  @Hassiai

  Posted over 2 years ago

  Replace the div <div> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give the alt attribute of the img a value. its value is the description of the image.

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded

  To center the div on the page using grid, add align-content: center and min-height: 100vh to the body.

  To center .container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  align-content: center;
  justify-content: center;
  }
  

  There is no need to give the div a margin value. Reduce the padding, max-width and gap values of the div for it to be equivalent to the design. max-width: 320px, paddding:16px and gap: 16px

  Give h1 and p the same font-size of 15px and the same margin-left and margin-right values . Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  00