QR code component with HTML and CSS

Community feedback

• 

  Alex•3,130

  @Alex-Archer-I

  Posted 11 months ago

  Hey!

  Congrats with your first challenge! Well, first here at least, as I can see you have some exp already =) It's cool!

  Here is a few tips.

  • It's better to use rem values at least for font sizes. It's a relative values which depends on browsers font settings, so users could change them.
  • font-optical-sizing: auto; and font-style: normal; are default values so you doesn't have to specify them.
  • Also as the whole page share one font family, you can apply it once. For example on the container element. All content elements inherited it and you doesn't have to repeat it so much.

  Hope that helps =)

  By the by, I love emoji in commit messages =)

  22

  Marked as helpful
• 

  Italo Régis•40

  @dev-italoregis

  Posted 11 months ago

  Your repo' is so organized and your solution is exactly the same as the design. Any tips how I can organize my repos? I saw that you didn't used semantic HTML. Is probably better to get used to use semantics tags. The CSS is very organized but I believe that has some extra code that didn't need to be used, tho.

  11

  Marked as helpful