@Hassiai
Posted
Replace<div class="container">with the main tag, <p class="bold"> with <h1>and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .container on the page using flexbox, add min-height: 100vh to the body. There is no need for align-content in the body. flexbox has no align-content rather its grid that has align-content.
To center .container on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
there is no need for position absolute and it properties in .container to center .container.
Give .container a padding value for all the sides and give the img a max-width of 100% and a border-radius value, the rest are not needed.
Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
There is no need to us p
Marked as helpful