qr code component with tailwind

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • For a responsive and resizable component, consider using max-width for the width of the component with max-w-[320px](max-width: 320px;)

  • Use min-h-screen (min-height: 100vh) instead of h-screen. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  I hope you find it useful! 😄

  Happy coding!

  21

  Marked as helpful
• 

  Bn-Bushra•290

  @Bn-Bushra

  Posted over 1 year ago

  Well done These are things I think you should note in this solution:

  • Removing the attributions before submission.
  • Editing the template README before pushing to GitHub.
  • I feel the project is pretty basic for the tailwind framework. Good understanding and use of CSS will make the usage of such framework a work over, and makes us better understand how it works.
  • Just structure the elements semantically as possible and make the class names descriptive as possible.
  • So that you will be able to add styles to the target elements easily.

  10

  Marked as helpful