Skip to content
Submitted about 2 years ago

QR code component - Working with basic HTML and CSS

Josh•100
@Joshua-Farr
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Putting together some basic CSS and HTML to build this QR code.

Would love some feedback to know if I'm making any serious coding mistakes.

Any feedback is greatly appreciated!

Code

Please log in to post a comment

Log in

Community feedback

  • Grace•32,130
    @grace-snow

    There's a few important changes needed on this

    1. height 100vh should be min-height. You never want to limit height of container elements (including body)
    2. similar, the card must not have a height either. It does not need a min height
    3. the width on the card should be a max-width and should be in rem
    4. font size must never ever be in px. Use rem. I've written a post about this

    One more point is more of a recommendation - the alt text on the image should really say where the QR code is going to. QR code to... Where

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord