Skip to content
Submitted 4 months ago

QR Code Component

Nilesh•10
@Gensys09
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • P
    Øystein Håberg•13,260
    @Islandstone89

    Hi there, well done!

    I have inspected your code, and have the following suggestions. I hope my feedback is clear and helpful :)

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

    • You don't need to wrap the image in a <div>. I would move class="qr-box to the image itself, and remove the <div>.

    • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    CSS:

    • Make a habit of including a modern CSS Reset at the top of the stylesheet.

    • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

    • The font for this challenge is "Outfit", not "Arial". Since "Outfit" is a sans-serif font, you should also use sans-serif as a fallback font, not serif. Put font-family: "Outfit", sans-serif on the <body> and remove it elsewhere - the children of the <body> inherit the font from their parent.

    • Remove the max-height on the card - you should never limit the height of elements containing text, as the text will overflow if it grows taller than the fixed size. Always let the content, along with margin and padding determine the height.

    • max-width on the card should be in rem. Around 20rem works well.

    • On the image, add display: block and height: auto. Remove max-height and change max-width: 320px to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord