QR Code Component

Community feedback

• 

  P

  Daniel 🛸•44,790

  @danielmrz-dev

  Posted over 1 year ago

  Hello @mehalimes!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  01

  Marked as helpful
• 

  Vijay Choudhary•200

  @scriptyvijay

  Posted over 1 year ago

  Well You've created good no doubt, But you need to improve padding and font size.

  As you can see at qr image above there's some negative space.

  And according to design your font looks too bold.(Font weight) to know more about font weight check style guide.

  You can also fix some negative spaces in your design also.

  01

  Marked as helpful