Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

redizorky• 320

@redizork

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Nothing to write.

What challenges did you encounter, and how did you overcome them?

Nothing to write.

What specific areas of your project would you like help with?

Nothing to write.

Community feedback

P

@Islandstone89

Posted

Good job, Neven!

A few suggestions:

HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • The alt text must also say where it leads(frontendmentor website).

CSS:

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Do NOT change the default font size on html.

  • Remove overflow: hidden, it is not needed.

  • max-width on the card should be in rem. Change it to 20rem, which equals 320px.

Marked as helpful

0
redizorky• 320

@redizork

Posted

Thank you, I will consider your suggestion :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord