Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Componet

#next#tailwind-css#typescript
P
Dev Killianโ€ข 100

@DevK-Eire

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feel free to leave a comment

Community feedback

Daniel ๐Ÿ›ธโ€ข 36,160

@danielmrz-dev

Posted

Hello @DevK-Eire!

Your solution looks excelent!

I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <p>. The tag <p> is meant for paragraphs, like you correctly did on the text Scan the QR code to visit Frontend Mentor and take your coding skills to the next level. For titles, though, we have the HTML Headings, the tags <h1> to <h6>.

And here's a quick guide on how to use them:

Unlike what most people think, it's not just about the size and weight of the text.

๐Ÿ“Œ The <h1> to <h6> tags are used to define HTML headings.

๐Ÿ“Œ <h1> defines the most important heading.

๐Ÿ“Œ <h6> defines the least important heading.

๐Ÿ“Œ Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, you did a great job!

Marked as helpful

0

P
Dev Killianโ€ข 100

@DevK-Eire

Posted

@danielmrz-dev

Thanks so much for the advice, I will keep that in mind :)

0

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • The <div> tag can be useful for styling and positioning, but it doesn't convey any semantic meaning. Instead, consider using more semantic elements like <p> to better describe the type of content. e.g.: <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>.
  • Don't use a height in the text; it will cause it to overflow, and that's why there is no space between the two paragraphs of your solution

I hope you find it useful! ๐Ÿ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

0

P
Dev Killianโ€ข 100

@DevK-Eire

Posted

@MelvinAguilar thanks so much for your feedback. I have added <p> :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord