Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Design

@Jwalt95

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


How do you think I can improve my code?

Community feedback

Vanza Setiaβ€’ 27,835

@vanzasetia

Posted

Hi Jean! πŸ‘‹

Congratulations on finishing this challenge! πŸ‘

I recommend removing all the <div> elements. You do not need to wrap every element with a <div>. For example, you can make the <img> as a block element (display: block) and set max-width: 100% to prevent the image from overflowing.

For the alternative text, I recommend telling "what the image is". In this case, it is a QR code that will redirect the users to frontendmentor.io. Also, you do not need to write the word "image" on the alternative text. Users will already know that it is an image. I recommend reading Quick tip: Using alt text properly - The A11Y Project.

I hope this helps. Happy coding! πŸ‘

Marked as helpful

0

@Jwalt95

Posted

Thank you very much for the tips@vanzasetia

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord