QR code design

Community feedback

• 

  P

  Øystein Håberg•13,280

  @Islandstone89

  Posted 11 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • You don't need any divs, except for the div holding the card content.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • Move background-color: hsl(212, 45%, 89%); from * to body.

  • You don't need to set anything on html, so remove that selector.

  • You can remove margin: 0 on body, as that is set on all elements using the universal selector *.

  • On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths and heights in px and %. Setting fixed widths and heights in px is especially dangerous, as it easily causes overflow. Never set a fixed height on text elements: this will lead to overflow if the content grows taller than the set size. Always let the content (along with margin and padding) decide the height.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value. Remove text-align: justify.

  • Likewise, font-family only needs to be set on body - remove it elsewhere.

  • On the image, replace width with max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  02

  Marked as helpful