Not Found
Not Found
Not Found
Failed to decode param 'V%E1clav'
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code exercise

#styled-components#webflow#fresh
Sandraβ€’ 60

@sancoza

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Sweet task. Good for practice. For beginners.

Community feedback

P
visualdennisβ€’ 8,255

@visualdenniss

Posted

Hello Sandra :)

congrats on completing the challenge successfully! Nice result.

However there seems to be couple issues to work on. To name a few: Giving a height: 60vh; is not a good idea, because it will stretch and squeeze depending on the screen size and cause unwanted paddings etc. It is best to avoid giving any fixed height or a height using percentages like this, instead just let the content of container determine the height. Use paddings and margins instead to tweak the look.

The color of the body text seems to be too bright, so using a darker value would improve the contrast and reability.

Hope you find this feedback helpful!

Marked as helpful

0

Sandraβ€’ 60

@sancoza

Posted

@visualdenniss Thanks a lot for your help. It means a lot to me. I will fix the code. All the best in your future work.

1
Abdul Khalid πŸš€β€’ 72,140

@0xabdulkhalid

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
  • So we want to add a level-one heading to improve accessibility
  • Example: <h1>Improve your front-end skills by building projects</h1>
  • If you have any questions or need further clarification, and feel free to reach out to me.
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Sandraβ€’ 60

@sancoza

Posted

@0xAbdulKhalid Thanks a lot for your help. It means a lot to me. I will fix the code. All the best in your future work. If something is not clear to me, now I know I can contact you. Thank you, dear friend.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord