QR Code - first FEM challenge

Community feedback

• 

  Hassia Issah•50,410

  @Hassiai

  Posted over 2 years ago

  Replace <div class="container"> with the main tag, <span class="title"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .container on the page using flexbox, add min-height:100vh to the body.

  For a responsive content, there is no need to give .container a height value and replace its width with max-width. Give the img a max-width of 100% and a border-radius value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  00

  Marked as helpful
• 

  RabicaTahir•500

  @RabicaTahir

  Posted over 2 years ago

  Asalam o Alaikum! @gustavo-atanazio. 🎯Congratulations on completing the challenge !

  💬I have some suggestions about your code.

  HTML 🔔:

  ▪ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag.

  Click & Wrap the code

  <div class="container">

  ▪ Best practice is to ensure that the beginning of a page's main content starts with a h1 element.

  Click & Replace

  <span class="title">Improve your front-end skills by building projects</span>

  CSS: 🎨

  📍▪ Instead of using pixels in font-size, using relative units like em or rem is a good practice.

  I hope you find it useful! By the way, the solution was great. 🙌💯

  Enjoy coding, Stay Safe! 🤞

  00

  Marked as helpful