Skip to content
Submitted almost 2 years ago

QR CODE GRID & CSS

3RN35T0#93•10
@AlonsoErnesto
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • Sachin•830
    @Sachin-Mahato

    IMG and meta are not self-closing tags. here are a few links img. meta check and learn about these things and it will not take that much time and other useful links for css reset;

  • _nehal💎•6,710
    @NehalSahu8055

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    • Replace height with min-height in wrapper.
    .wrapper{
min-height: 100vh;
}
    • Use Semantics for the proper design of your code.
    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribution` inside `footer`
</body>

    -For non-decorative images give meaningful and descriptive alt like alt= "QR code to Frontend Mentor website".

    • Every site must have one h1 element describing the main content of the page.

    • So, Add a level-one heading instead of h2 to improve accessibility.

    • <h1>Improve your front-end skills by building projects</h1>

    I hope you find this helpful.

    Happy coding😄

  • Abdul Khaliq 🚀•72,360
    @0xabdulkhaliq

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    QR iMAGE ALT TEXT 📸:

    • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.
    • The alt with qr-code is not even explaining for what the QR image need to be used.
    • So update the alt with meaningful text which explains like QR code to frontendmentor.io
    • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord