QR Code - [HTML, CSS, SASS, Flexbox, CSS Grid]

Community feedback

• 

  dimar hanung•560

  @dimar-hanung

  Posted over 2 years ago

  Hi there 👋, congrats, Congratulations on completing the challenge, i have some feedback might useful for you.

  That i like:

  1. first i like your slicing result is very similar, just little difference in shadow and font.
  2. i like the way you separate sections into a structured folder
  3. the responsive is pretty good, even until galaxy fold 🙌

  My feedback:

  1. my opinion the comment in your code is not needed, example <!-- CARD QR IMAGE ->, because your classname that you created already represents what it is for, example class="card__qr-link" , by removing the comment it will make it clearer

  anyways good solution!, i hope my feedback can be useful, thanks 🙌

  11