Skip to content
Submitted about 1 year ago

Qr code - HTML/CSS - Visual Code Studio

P-Mingi•170
@P-Mingi
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I think that i did a good job, i probably have a problem with the size of my main container, but the rest is fine i think. It shrink well to a smaller size page format.

What challenges did you encounter, and how did you overcome them?

I think the way to make it responsive, i don't know if i used the good method by using a media query, i wished i could do it without using any, but i don't think it was possible.

What specific areas of your project would you like help with?

With my Responsive method, did i did well by using a media query, should i have use it at a higher width, or was there another way to do it ?

Code
Couldn’t fetch repository

Please log in to post a comment

Log in

Community feedback

  • William•40
    @Dartheryon

    I think it is a good work. It could be better if you take a look on the figma file and the meassures defined on it :) Taking a look into your repo, I can see you did not change the readme as the exercise suggest us to. It would be nices if you take the time to makeit, using the readme-template provided, as a guide.

    It seems there might be some accesibilites issues you can improve. I refer to landmarks, specially.

    You use a h2 tag without using previously a h1 tag. Remember that those tags are not a matter of size, but a semantic important part of the document. Please take a look on it :)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord