QR code in tailwind css

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted over 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Using h-screen (height: 100vh) to center the element can cause problems with the layout of the page on smaller screens, such as in landscape view on a mobile device.

    On smaller screens, such as in landscape view on a mobile device, the height of the viewport may be less than the height of the content of the page. In this case, using h-screen will cause the content of the page to be hidden behind the body element.

    Here is an image of how it would look on a mobile device (taking into account the scroll): screencapture-ui-lib-chi-vercel-app-qr-2023-02-02-12_39_39

    To avoid this problem, it is generally recommended to use min-h-screen (min-height: 100vh) instead of h-screen. This will ensure that the content of the page is always visible.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  31
• 

  Sandro•1,150

  @sandro21-glitch

  Posted over 2 years ago

  The design is simple and straightforward, with a clear focus on the QR code component.

  The color palette is appropriate, and the font choices are legible, but i don't like text layout

  Overall, the design seems to be well executed and effective in presenting the QR code component.

  good luck

  11