Hi, overall this is very good. I can spot a few issues in this code, but these are very common things so don't get discouraged. Refactoring them will set you up well for the next challenge...
- All content should be contained within landmarks. This needs a main as the container. The attribution should be moved outside of this and should be a footer.
- The image is really important content so deserves a more meaningful alt description. In this case the alt should say what the image is (QR code) and where it goes (to FrontendMentor.io).
- You must use a heading for the heading content. As this component would not serve as a page title the heading level should be h2.
- Get into the habit of including a full modern css reset at the start of the styles in every project. Andy Bell or Josh Comeau both have good ones you can look up and use.
- All of the css you have on the container class can go on the body instead.
- The card component should have a little margin on all sides so it can't hit screen edges. (Or a wrapping element could have padding for the same purpose)
Marked as helpful
1
P
Carsten Körner• 170
@carstenkoerner
Posted
@grace-snow Hi Grace, thank you for your helpful and interesting advice. I have implemented all the points and uploaded the update.
0
