Submitted about 3 years ago

QR code page with html, css and bootstrap

@saumitr

A solution to the QR code component challenge

Solution retrospective

This is my first submission on frontend mentor. I have tweaked mostly all the css property. Let me know if I have followed best practices properly. Any other feedback is greatly appreciated.

Code

Please log in to post a comment

Community feedback

Ken•935
@kenreibman
Posted about 3 years ago
Great job on your first submission!

I noticed that in your index.html you had
```
    html body {
      background-color: hsl(212, 45%, 89%);
    }
```
you can just have in your style.css
```
body {
      background-color: hsl(212, 45%, 89%);
}
```
I also noticed that you have a .body in your style.css as well which is looking for an element with the class="body" I think you were meaning to select the body element as a whole and center items within in. In that case, you should have also just done
```
body {
    min-height: 100vh; <--- *NOTE I also changed this to min-height as it's better practice
    width: auto;
    display: flex;
    align-items: center;
  }
```
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord