Skip to content
  • Learning paths
  • Challenges
  • Solutions
  • Articles
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

QR code page with html, css and bootstrap

Saumitra Paira•10
@saumitr
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my first submission on frontend mentor. I have tweaked mostly all the css property. Let me know if I have followed best practices properly. Any other feedback is greatly appreciated.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ken•935
    @kenreibman
    Posted about 3 years ago

    Great job on your first submission!

    I noticed that in your index.html you had

        html body {
          background-color: hsl(212, 45%, 89%);
        }
    

    you can just have in your style.css

    body {
          background-color: hsl(212, 45%, 89%);
    }
    

    I also noticed that you have a .body in your style.css as well which is looking for an element with the class="body" I think you were meaning to select the body element as a whole and center items within in. In that case, you should have also just done

    body {
        min-height: 100vh; <--- *NOTE I also changed this to min-height as it's better practice
        width: auto;
        display: flex;
        align-items: center;
      }
    
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub