QR code page with HTML/CSS

Community feedback

• 

  Hexer•3,620

  @EmmanuelHexer

  Posted over 3 years ago

  Good job man. Keep it up

  • One tip i can give you is to wrap your card with main element to fix accessibility issues.

  11

  Marked as helpful
• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 3 years ago

  Hi AnaRou, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  11

  Marked as helpful