
Please log in to post a comment
Log in with GitHubCommunity feedback
- @EvansKabubii
From what I've seen on the preview, I think it's worked well with the sizing but I think you should try using measurements like vh (view height) and vw (view width) to set sizes of the container and other components. Here's why:
-As you add more things to your page, you'll need the components to be able to dynamically change sizes and not be so hard coded into a specific size. It will save you headache and creating many media queries for different screen sizes.
Here it worked well because the only thing on the page was the qr code but if you inspect and make the screen smaller and smaller, you'll see that the QR code card becomes bigger than the screen and you can't read it all anymore.
Still though, this was an awesome project, and I think it looks great. It's basically the same as the design. Keep it up bro
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord