👾Hi @Carolkiarie, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
<main> instead of
<div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.
2.Add the website favicon inserting the svg image inside the
<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">
3.To maintain the card responsive use
max-width instead of
width this way you allow the content to be flexible. The difference between
width is that
width is fixed and
max-width has a maximum size but can shrink to fit the content.
4.Use relative units like
rem or em instead of
px to have a better performance when your page content resizes on different screens and devices.
EM does not just apply to font size, but all sizes as well. To save your time you can code your whole page using
px and then in the end use a VsCode plugin called
px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
Marked as helpful
@correlucas Thank you so much for the feedback. Quick question kindly. in the style sheet guide, there are values given for the widths of the mobile and the desktop (- Mobile: 375px
- Desktop: 1440px) . Where exactly do you use them and what was the need of them being included in the stylesheet. Thank you for your time!