Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr Code solution

Ahmed Medhatโ€ข 20

@AhmedMedhat77

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Finneyโ€ข 3,030

@Finney06

Posted

Hello Ahmed ๐Ÿ‘‹. Good job on completing the challenge !

Here are some suggestions regarding your code that may be of interest to you.

HTML ๐Ÿท๏ธ:

To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections you can also use ARIA landmarks such as <header role="banner"> and <footer role="contentinfo"> to provide additional information about the purpose of each section to assistive technologies.

I hope you find it helpful!๐Ÿ˜ Above all, the solution you submitted is ๐Ÿ‘Œ. ๐ŸŽ‰Happy coding!

Marked as helpful

0

Ahmed Medhatโ€ข 20

@AhmedMedhat77

Posted

@Finney06 Thank You <3

0
Francisco Carrilloโ€ข 5,560

@frank-itachi

Posted

Hello there ๐Ÿ‘‹. You did a good job!

I have some suggestions about your code that might interest you.

HTML ๐Ÿ“„:

  • The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can increase by one if you need to use more headings or subtitles in your html code. So replace the <h5> by the <h1> tag.

CSS๐ŸŽจ:

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

I hope you find it useful! ๐Ÿ˜๐Ÿ˜ Above all, the solution you submitted is great๐Ÿ‘Œ!

Happy <coding /> ๐Ÿ˜Ž!

Marked as helpful

0

Ahmed Medhatโ€ข 20

@AhmedMedhat77

Posted

@frank-itachi thank you <3

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord