Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

QR Code - Solution

bootstrap, sass/scss, bem
Nathan Weber•80
@WorldWideWeb-er
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


When building websites, would you recommend building them mobile first, or desktop first?

Follow up question: Is there any particular reason to build them mobile / desktop first, then adapt the code for the other sizes?

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Juanca•220
    @juancaorg
    Posted almost 3 years ago

    Hi Nathan 👋!

    Answering your questions, based on my experience:

    It depends, but if you are building a website for a general audience (i.e. everyone), I would recommend almost every time building mobile first.

    Some reasons:

    • It's easier to build. You may have learned to build a website based on the desktop design, but if you pay attention, desktop designs are generally more complex layouts. Mobile are, most of the time, a single column and are less complex because of their width constrains.
    • Most users use mobile. Plain simple, if you're building for everyone, most of your traffic is going to be mobile.
    • Space. Similar to the first reason. It's easier to expand your layout when you have built mobile first, instead of the other way around and finding out that you may have ran out of space on your viewport, or that you'll have to remove some elements instead of adding elements, which in my opinion, is easier.

    Nevertheless, these reasons are mostly opinions based on my experience. I would recommend you to read more about Mobile first on this MDN article.

    Have a good one, and keep going! 🙌

    Marked as helpful
  • P
    Miran Legin•740
    @miranlegin
    Posted almost 3 years ago

    Hi Nathan,

    regarding question about building websites i would say that in my experience it all comes down to what are you building. For example, if you are working on this project it really isn't important because it looks the same on all resolutions and orientations. Only the side padding on the body is getting smaller or larger depending on viewport. My personal preference is building with least amount of code and minimum overrides and that is sometimes mobile first and other times desktop first approach. I try to keep styles that are uniformed across the width of the browser as a base and only use media queries when there is need to add additional styling.

    Hope that makes sense.

    Keep coding! Cheers!

  • Adriano•42,890
    @AdrianoEscarabote
    Posted almost 3 years ago

    Hi Nathan Weber, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Document should have one main landmark, you could have put all the content inside the main tag click here

    2- Page should contain a level-one heading, you could have replaced p.improv with h1 click here

    The rest is great!! Hope it helps... 👍

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub