Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Qr code solution using HTML & CSS

Samuel Nerat•120
@Samuelnerat
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am most proud of the design and how I got to achieve it with plain HTML and CSS. Next time I would like to work with other technologies to achieve the interface

What challenges did you encounter, and how did you overcome them?

The challenge I encountered at first was responsiveness I overcame it by researching a solution

What specific areas of your project would you like help with?

I would like feedback on the code. if there is anything I should have used to make it more efficient or easier.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Wuffskyarts•60
    @Wuffskyarts
    Posted about 1 year ago

    First, I think you did amazing on the final design's result! It looks perfect. I can relate to learning the responsiveness of a webpage; it can be quite a pain.

    Looking at the responsiveness, I think you nailed it! It resizes perfectly.

    A similar issue I ran into, I think there could be some minor tweaks to your <div>'s. The <div class="container"> works as the parent container. You can keep all the child elements in another div (img, h1, p) inside the parent div without separating the image and text (h1, p) with two different divs.

    You can define .child img, .child p and .child" h1 in your CSS. Another suggestion is your "*" all tag; you can determine the default text style to remove the .child p tag within the CSS.

    • { font-size: 15px; font-family: "outfit," sans-serif; text-align: center; }

    I think you did fantastically, and your code looks lovely! These minor tweaks can clean up your CSS for much larger projects (500+ lines) :)

    I can relate to this project; it took me a while, and I'm still learning HTML, CSS and JS.

    Marked as helpful
  • Julie•130
    @salentipy
    Posted about 1 year ago

    Your code looks nice to me. I'm still learning all about responsivity myself and dealing with some issues there, so I'm afraid I don't have any kind of specific feedback to offer in that regard. Semantic HTML looks good, in my opinion. Nice job!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub