Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

QR code using basic HTML and CSS

yAshr•60
@Exquisite10
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Please tell if there's any other easier method to make this challenge complete and what is the color of background which is present in the question?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Travolgi 🍕•31,300
    @denielden
    Posted over 3 years ago

    Hi yAshr, good job! Congratulations on completing the challenge.

    I had a look at your solution and I have a few suggestions for you:

    • remove the margin and top property from card class.
    • remove max-width from body
    • use Flexbox for center the card to the body. Read here -> flex guide
    • add heigth: 100vh to body because Flexbox aligns to the size of the parent container
    • Adding main tag for Accessibility and wrap the card inside

    Hope this help and happy coding :)

    Marked as helpful
  • Account deletedPosted over 3 years ago

    Hello there! 👋

    Congratulations on finishing your challenge! 🎉

    I have some feedback on this solution:

    • Always Use Semantic HTML instead of div like <main> <header> , etc for more info

    • Remove the position,margin, etc from the card element add to the body these properties to center the card display:flex: justifiy-content; center; align-items:center; min-height:100vh; and remove the max-width from the body

    • Add A Max Width to there paragraph to make it look exactly like the design max-width:240px

    if my solution has helped you do not forget to mark this as helpful!

    Marked as helpful
  • Naveen Gumaste•10,420
    @NaveenGumaste
    Posted over 3 years ago

    Hay ! yAshr Good Job on challenge

    These below mentioned tricks will help you remove any Accessibility Issues

    -> Add Main tag after body <main class="container"></main>

    -> Learn more on accessibility issues

    Keep up the good work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub