Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr code using display and position css

Ohad 50

@ohad331

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My first Challenge after a lot of time I didn't code. Would love to get some tips and insights about my solution.

Thanks!

Community feedback

Adriano 34,000

@AdrianoEscarabote

Posted

Hi @ohad331, how are you?

You did a great job on this challenge, but I have a few tips I think you'll like:

1- Document should have one main landmark, you could have put all the content inside the main tag. click here

2- Page should contain a level-one heading, you could change h2 to h1 click here

To have a better centering of the .card I put:

.card { min height: 100vh; }

I noticed that the card is varying a lot in size as the screen resolution increases, to solve this I put an absolute unit of measurement (px), prioritize the use of relative units (%) only in lower resolutions.

.Card { width: 320px; height: 500px; }

The rest is great. Hope it helps... 👍

Marked as helpful

0

Ohad 50

@ohad331

Posted

Hi @AdrianoEscarabote, Thank you very much my friend!! Help a lot :)

1
Adriano 34,000

@AdrianoEscarabote

Posted

@ohad331 no problem, keep coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord