QR code using HTML and CSS

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 3 years ago

  Hi Felipe, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • remove all margin from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px or % try to use relative units of measurement like rem -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  10

  Marked as helpful
• 

  Sebastian Arevalo•130

  @arevalosebastian

  Posted over 3 years ago

  Hello there, this is my first comment trying to feedback someone, I'm not an expert too I started not long ago so everyelse is reading this I hope leave a better feedback, I'm learning english aswell so I hope all I want to say its understandable...

  First of all, I learned or was taught that always try to use classes for styling. For example with h1 or p in your HTML you're not using classes and using a general selector in the stylesheet so you don't have unexpected errors with specificity, general bugs, etc.

  Second, I was taught that is better start styling mobile size first so you get styles for mobiles and desktop sizes.

  Everything else you've done a good job, keep the work, and keep an eye with the accesibilty issues :)

  Have a good day.

  10

  Marked as helpful