@denielden
Posted
Hi Felipe, good job! I took some time to look at your code and have some ideas for improving it:
- add
main
tag and wrap the card for improve the Accessibility - remove all
margin
fromcard
class - try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px or %
try to use relative units of measurement likerem
-> read here
Overall you did well 😉
Hope this help and happy coding!
Marked as helpful