Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code using HTML and CSS

@BoxyPipesnake

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi!! Could you please tell me how I can improve my code

Community feedback

Travolgi 🍕 31,500

@denielden

Posted

Hi Felipe, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • remove all margin from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px or % try to use relative units of measurement like rem -> read here

Overall you did well 😉

Hope this help and happy coding!

Marked as helpful

1

@arevalosebastian

Posted

Hello there, this is my first comment trying to feedback someone, I'm not an expert too I started not long ago so everyelse is reading this I hope leave a better feedback, I'm learning english aswell so I hope all I want to say its understandable...

First of all, I learned or was taught that always try to use classes for styling. For example with h1 or p in your HTML you're not using classes and using a general selector in the stylesheet so you don't have unexpected errors with specificity, general bugs, etc.

Second, I was taught that is better start styling mobile size first so you get styles for mobiles and desktop sizes.

Everything else you've done a good job, keep the work, and keep an eye with the accesibilty issues :)

Have a good day.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord