QR Code using HTML and CSS

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,860

  @catherineisonline

  Posted 4 months ago

  Hello, Jidan, great solution and almost matches the goal. I know this is an old project but I'm here to review it as you ended up in my learning path :)

  A couple of things I have to add that might not be very critical but may be good to know or consider:

  • The alt text for the QR image is too vague, if you decide to add it then it's better to make it more descriptive e.g."QR code linking to Frontend Mentor website"
  • Maybe you had some idea but were not sure why you used place-self: end center; for the main instead of simply place-self: center;
  • The font size for the #details below 14px isn't really a good idea - way too small and hard to read 0.85rem
  • It doesn't affect this project much but it's nice to have a habit of removing extra comments that serve no purpose

  00
• 

  WaelBenseghir•160

  @WaelBenseghir

  Posted 11 months ago

  Good design

  00