Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR CODE - Using HTML/CSS

@markuscoding

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, This is my first project. Please give me your feedback so i can learn more and apply from next project thankyou so much

Community feedback

@iammukeshmahato

Posted

Hi Mark!

Your work looks good, but there is some accessibility issues report generated by Frontend Mentor.

  1. Images must have alternate text
  2. Document should have one main landmark
  3. Page should contain a level-one heading
  4. All page content should be contained by landmarks
  • add alt attribute to img tag. eg: <img class="image-qr" src="images/image-qr-code.png" alt="qr-code"/>

  • Put you <div class="qr-card"> into a <main> tag or <section> tag.

  • You have used <h2> tag, instead you can use <h1> tag and set the font-size as required.

  • You have a div of class attribution, put the div in *footer tag.

By following the above steps you can fix the accessibility issues. You have some mis-matched in image size which can easily be fixed.

You can have a look to my solution. click here to live preview my solution.

If you have any doubts or questions do not hesitate to ask.

Keep Coding! Keep Learning!

1

@markuscoding

Posted

@mukeshmahato843

Hi Mukesh

Thank you so much for your feedback this helps me a lot to correct my error, I will do all the things you mention above to avoid some accessibility issues .

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord