Skip to content
Submitted almost 3 years ago

QR Code Website Using Flexbox and Position

Bernie•70
@SoftPillow20
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • Lucas 👾•104,160
    @correlucas

    👾Hello Bernie, Congratulations on completing this challenge!

    Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:

    The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
  • romila•3,550
    @romila2003

    Hi Bernie,

    Congratulations 🎉 for completing this challenge, it was a great attempt. The card looks great and looks great in both mobile and desktop screen however one thing I want to mention is to change the height property from 720px to 100vh as this would indicate the whole height of the screen which you can see. This height will change depending on your screen size since phones and desktop screens may vary in screen sizes.

    Overall, great attempt and wish you the best for your future projects so keep coding 👍.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord