Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 2 months ago

QR Component

StickyStick35•10
@StickyStick35
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What specific areas of your project would you like help with?

I would like to get a feedback over all my project

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Nuradeen Mohammed•290
    @nursh
    Posted 2 months ago

    HTML

    • Change your <h4> tag to a <p> tag. The second text is a paragraph not a heading.
    • add some descriptive text to your image alt attribute. This is for accessibility. Something like Product QR code.
    • Use only one container for your content. Remove the second div with the .contain class. You want to avoid unnecessary nesting in your code. It will be difficult to read and debug

    CSS

    • To center the .container container, Set the body to take up the width of the window, and set it's display to grid and place-items to center. Using the following code
    body {
      /** your other declarations here **/
      min-height: 100vh;
      display: grid;
      place-items: center;
    }
    
    • Remove the margin-top from the .container class. It should be centered. Also avoid using magic numbers in your code.
    • Move the code in the .contain class into the .container class and delete the .contain as it is no longer needed.
    • Avoid setting font-size in px units. Use responsive units like rem.
    • Avoid setting explicit width and height using px units on a container. Let the content determine the size of the container. If you want to set dimensions, use units like rem and em so that it is responsive. Set the max-width of the container to be max-width: 20rem for example, then let the browser adjust the size
    • For the image, also remove the width and height. Give it a max-width: 100% and set the height: auto. This makes sure the image is within its parent container and then the height is self-determined
  • Adeline•70
    @AdelineSey
    Posted 2 months ago

    Overall, it looks great! The colors and alignment of your live site match the reference photo well.

    Few things I'd adjust in your code:

    • Line 12: Your <div> opening tag is missing the </div> closing tag.
    • Line 14: Your image alt is empty and should have a brief description of the image.
    • Line 16: Your opening tag is <h4> but your closing tag is </h2>. They should both be the same h-number.

    Hope this helps 🙂

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub