QR component i have used HTML and CSS

Solution retrospective
i am proud of my coding skills with javascript, and i wish to improve my css skills and react skills more.
next time would like to start with the mobile version before working with desktop version
What challenges did you encounter, and how did you overcome them?most of the time challenges that i encounter is having the element resize the way i want them to. most of the time child elements will over flow.
What specific areas of your project would you like help with?my css positioning and responsiveness, and selecting fonts is a bit challenging for me.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @skyv26
Hi @Thapelo12345, 👋
Your project looks great and shows a lot of effort! 🚀 I have a few suggestions to help enhance the quality and maintainability of your code:
- Remove Commented Code in HTML 📝
- Commented code can make your HTML less readable and cluttered, which affects maintainability and professionalism.
- Consider removing the commented sections from these lines:
- Simplify CSS Code 🎨
- Unnecessary properties in your CSS can make the code more complex and harder to debug. Removing the commented sections will simplify your CSS and improve clarity.
- Example cleanup suggestion for your
div
styles:div { border: 1px solid white; display: flex; flex-direction: column; align-items: center; max-width: 320px; margin: auto; padding: 4%; border-radius: 8px; background-color: hsl(0, 0%, 100%); box-shadow: 1px 5px 70px hsl(210, 13%, 82%); }
- Removing unused properties like
flex-wrap
,min-width
, andmax-height
will make your styles more concise.
- Use Classes for Styling Instead of IDs or Tags 💡
- Using classes instead of IDs or tag names for styling improves readability, maintainability, and reusability. It aligns with best practices in web development and ensures styles can be reused without duplication.
- Example: Replace
#some-id
with.some-class
in your stylesheet and update the corresponding HTML.
Let me know if you need further clarification or help with any of these suggestions! Keep up the excellent work, and feel free to reach out for feedback anytime. 🌟
Happy coding! 💻✨
- Remove Commented Code in HTML 📝
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord