QR component

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 3 years ago

  Hi Korey, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all margin from main class because with flex they are superfluous
  • use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here
  • instead of using margin for the inside space of element use padding

  Overall you did well 😉

  Hope this help and happy coding!

  00

  Marked as helpful
• 

  P

  Jean Ruiz•570

  @jeancarlosruiz

  Posted over 3 years ago

  Great job!

  Just a couple of feedback:

  • Use a main tag to avoid accessibility issues.
  • Use a footer tag in the attribution section to avoid accessibility issues.
  • CSS: is better practice and set values with rem and em instead of px. Here’s a video where you can learn why https://youtu.be/N5wpD9Ov_To and a link where you can learn about rem and em https://developer.mozilla.org/en-US/docs/Web/CSS/font-size.

  Happy coding! 😄

  00

  Marked as helpful