QR Component using Basic HTML and CSS

Solution retrospective
I was able to create the page with proper structured code and keeping it simple
What challenges did you encounter, and how did you overcome them?The challenges were:
- Using figma. I have little knowlege on figma. So many things, i took time to figure out things.
I haven't used any semantic tags in this project. I am not sure on which semantic tag can be used. Can someone help me on this.
Secondly on the guide these four criteria's were given: Mobile: 375px , Desktop: 1440px, WCAG requirements responsive.
I have made the container size 320px X 499px as per the design. Can someone help out on made changes to be made on project so as to meet the above mentioned criterias
Please log in to post a comment
Log in with GitHubCommunity feedback
- @asia272
These changes will improve the semantic structure of your HTML:
-
<div> to <main>
: Since the QR container represents the main content of the page, it should be wrapped inside<main>
instead of a generic<div>
. -
<p class="heading"> to <h1 class="heading">
: Headings should use proper heading tags (h1, h2, etc.) for better structure, readability, and accessibility
Marked as helpful -
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord