Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

QR Component using Vanilla CSS

Daniel Zeljko•50
@danielzeljko
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?
What challenges did you encounter, and how did you overcome them?
What specific areas of your project would you like help with?
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Alfrazgit•50
    @Alfrazgit
    Posted over 1 year ago

    Good job on positioning the card exactly where it needs to be. I couldn't figure it out.

  • Marcos Travaglini•6,230
    @Blackpachamame
    Posted over 1 year ago

    Good job!

    Maybe there are some things in the HTML to improve. You could remove a couple of unnecessary divs and layout it like this:

    <body>
      <main class="card">
            <img src="images/image-qr-code.png" alt="qr-code">
    
            <div class="card-body">
              <h5>Improve your front-end skills by building projects</h5>
              <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
            </div>
      </main>
      <footer class="attribution">
              Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
              Coded by <a href="https://github.com/danielzeljko">Daniel Zeljko</a>.
      </footer>
    </body>
    

    You can replace the main tag with article, both are valid.

    I would modify the CSS like this:

    html {
        margin: 0;
        padding: 0;
        box-sizing: border-box;
    }
    
    body {
        font-size: 15px;
        font-family: 'Outfit', sans-serif;
        background: var(--main-bg-color);
        line-height: normal;
        display: grid;
        place-content: center; /* Center items, like using a justify-content: center and align-items: center */
        min-height: 100vh; /* Adjusts to the height of the viewport */
        width: 100%;
    }
    
    .card {
        padding: 16px;
        border-radius: calc(var(--base-border-radius) * 2);
        max-width: 320px; /* Instead of a fixed width, the width is now reduced if the screen is smaller */
        min-height: 497px; /* Increase the height of the card if required */
        background: var(--card-bg-color);
        box-shadow: 0px 25px 25px 0px rgba(0, 0, 0, 0.05);
    }
    
    .card img {
        height: 288px;
        width: 288px;
        display: block; /* Remove white space below the image */
        border-radius: var(--base-border-radius);
    }
    
    .card-body {
        display: flex;
        flex-direction: column;
        align-items: center;
        text-align: center;
        /* height: 193px;  This is no longer necessary */
    }
    

    I think that's it, if you try it and there are any errors let me know.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub