QR6-code-component

Community feedback

• 

  EvtimEvtimov•30

  @evtimov-ptr

  Posted over 2 years ago

  First of all congratulations on completing this challenge. Now to what you could improve

  1. I see that in the HTML you have used the <br> tag few times. It is really a good practice to avoid using <br>. Instead what you can do is to use either <div>, <span> or <p> tag. In this challenge it's not a big deal, however in the future, please try to get used to the other tags.
  2. The alt property in the img is empty. It is always a good idea to check your structure from time to time just so you can avoid such mistakes.
  3. The card itself appears to not be aligned properly, and the problem is that you are setting margin-left and top on the img with different values, what you could do is to just simply shorthand this. if you say margin: 5px for instance. Using this it will apply the 5px on each side instead of manually declaring it with different values, that will completely mess with the alignment of the element.

  That was from me in terms of what you could improve. Good luck and happy coding 🙂

  00

  Marked as helpful
• 

  Panji•2,090

  @pperdana

  Posted over 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have some additional recommendations for your code that I think you'll find interesting and valuable.

  📌 Add <main> tag as semantic HTML in code

  • The <main> tag is a semantic HTML element that is used to define the main content of a web page.

  • The <main> tag should be used to wrap the primary content of a web page, such as the main article, section, or body of text.

  for example code:

  <main>
    <div class='container'>
      <h1>Article Title</h1>
      <p>Article content goes here...</p>
      .......................
    </div>
  </main>
  

  In the example above, the <main> tag is used to wrap the <div> tag, which contains the primary content of the web page. This tells both human readers and search engines that the content inside the <main> tag is the most important and relevant content on the page.

  I hope you found this helpful!

  Happy coding🤖

  00

  Marked as helpful
• 

  samaelWebDev•240

  @samaelwebdev

  Posted over 2 years ago

  your project looks amazing, however, you are missing the shadow, using the box-shadow property is pretty simple, however, the best advice that I can give you when not fully understanding how to use a property is to refer to either (https://www.w3schools.com/) or (https://developer.mozilla.org/en-US/) as you will be able to have an accurate reference on anything related to CSS and HTML plus much more, these websites are your best friends when it comes to learning such technologies.

  here is a link that explains exactly what the "box-shadow" property it, its uses, semantics etc etc. https://www.w3schools.com/cssref/css3_pr_box-shadow.php

  I hope this comment is comes handy to you.

  good luck and happy coding my friend.

  00

  Marked as helpful
• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted over 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="main-card"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00