Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

QRCode Challenge using Flex and MaxWidth

aztromel•40
@aztromel
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I really liked that I was able to understand how to implement flex and widths into my design in order to avoid making unnecessary responsive media queries. When it comes to the margin and padding I added, I think there are better solutions to get the desired design, however, I'm not sure yet.

What challenges did you encounter, and how did you overcome them?

The most difficult challenge for me was getting the margins of the card to not over extend and ruin the design. This was especially hard in the white background, because when I checked the site in phone width, it was really broken, but I managed to fix it by investigating more about how to manipulate the width and height.

What specific areas of your project would you like help with?

How can I make my design be responsive without the use of media queries? In the case of the widths and heights, is there a function that allows me to make the design responsive more easily instead of establishing a predetermined max height or width?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    JOSIANE FERMAO•170
    @josifermaodev
    Posted about 1 year ago

    You can make your design responsive without using media queries by using a few different approaches. Here are a few techniques that can help:

    1. Flexbox and Grid Layout:

    Both are great tools for creating flexible layouts that automatically adjust to the screen size.

    2. Relative Units:

    Using relative units like em, rem, vw, and vh can make your design more adaptable to different screen sizes.

    em and rem: Proportional to the font size of the element or root.

    vw and vh: Proportional to the width and height of the viewport.

    3. CSS Functions:

    CSS functions like calc(), min(), max(), and clamp() help you create dynamic values ​​that adjust to the context.

    4. Aspect Ratio:

    Maintaining the aspect ratio of elements can help you create designs that automatically adjust.

    5. CSS Custom Properties (Variables)

    Using CSS variables allows you to dynamically adjust your design based on global variables.

    These techniques can help make your design more flexible and adaptable to different screen sizes without relying solely on media queries.

    Analyzing your code

    I noticed an unnecessary overuse of tags:

    <div> there is no need to make so many divisions, a better way to deal with tags is to give classes to each one of them.

    <h1> It is better to use only one <h1> per page to maintain the correct semantic hierarchy and use <h2>, <h3>, etc., for subtitles.

    Instead of repeating tags to perform line breaks using the responsiveness methods above, by automatically delimiting the space you will already have responsive code.

    Here is an example of how to make the code cleaner and more functional:

    <div class="container">
        <div class="container__main">
          <img src="/images/image-qr-code.png" alt="Qrcode Frontend Mentor" class="container__main-image">
          <h1 class="container__main-title">Improve your front-end skills by building projects</h1>
          <p class="container__main-text">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
        </div>
      </div>
    

    Hope this helped!

  • hcolmenares•80
    @hcolmenares
    Posted about 1 year ago

    When you implement flexbox, you should be aware of the 'level' of the elements in the HTML. For example, I see that the card in your project is slightly off-center, and I notice that you use a container (in this case called 'flexbox') and then add the card.

    If the container does not occupy the full height and width of the screen, it can cause problems when centering elements.

    One way to fix this is to use flexbox properties on the 'body' tag as well, so you don't need to create another 'div' element to act as a container/flexbox because you only need the body and the card elements.

    Another way is to give the flexbox element 'height: 100vh' and 'width: 100vw'. This sets the size of the container to fill the entire screen.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub