Qrcode challenger using CSS and HTML

Community feedback

• 

  Andreas Remdt•950

  @andreasremdt

  Posted about 2 years ago

  Hey @ricardosilvasx,

  Congrats on solving the challenge, well done! Your solution looks good, I like that you wrapped everything in a main tag which is a good practice. Here are some additional suggestions:

  • Try and incorporate a heading. Every website needs at least one heading to explain the content. Always start with the highest level (h1) and then descend down when it makes sense. In this example, I would make the text Improve your front-end skills by building projects the main heading.
  • You don't need the div.qrcode, just apply the styles of it to the main element directly.
  • Your image doesn't have any width and height attributes, which I would advice you to set. They allow the browser to better calculate the image dimensions and hence optimize rendering, which results in a better loading experience.

  Keep up the good work and let me know if you have any questions!

  00

  Marked as helpful
• 

  Kamlesh Rajesh Yadav•5,040

  @Kamlesh0007

  Posted about 2 years ago

  Congratulations on completing the challenge!🎉. That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add some code in body tag to make the container center as well as responive as per design. Here's a code snippet that u need to add:

  body {
  background-color: hsl(212, 45%, 89%);
  display: flex;
  flex-direction: column;
  justify-content: center;
  min-height: 100vh;
  align-items: center;
  font-family: 'Outfit', sans-serif;
  }
  

  remove below code 
  .qrcode {
  margin-top: 250px; 
  
  }
  

  00

  Marked as helpful