Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Code Component

ZMBā€¢ 720

@ZMBAIG

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone,

Any comment or feedback with respect to this project, will be highly appreciated.

With regards,

ZM. Baig

Community feedback

Daniel šŸ›øā€¢ 38,690

@danielmrz-dev

Posted

Hello @ZMBAIG šŸ™‹šŸ½ā€ā™‚ļø

Your solution looks excellent!

I have a suggestion about your code that might interest you:

šŸ“Œ If you don't have the Figma design files, I recommend using a browser extension called Perfect Pixel.

It allows you to compare your finished project with the design images that come along when you download the project and check the (almost exact) dimensions. It's very useful!

I hope it helps you in future projects! šŸ˜Š

Other than that, great job!

0
Amerā€¢ 360

@amerrika

Posted

Hi ZM. Baig, I think you did a great job with the styling. My advice would be to not to make the qr-component using the main-element but to make it with a article-element or a div-element that would be placed inside the main-element. And, instead of section-element for heading and paragraph I think a better solution would be to use a div-element. Something like this:

<main>
    <article class="scan-container">
        <img>
        <div>
            <h1></h1>
            <p></p>
        </div>
    </article>
</main>

This way the code is more semantic.

Other than that, a great job.

Good luck with coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord