Hi there 👋,
Congratulations on completing your first challenge! 🥳👏🎉
I have some feedback for your consideration:
-
There are some landmark issues, you can fix it by changing the
<div class="center-screen">to<main class="center-screen">. More about landmarks here. -
Always have the
altattribute with <img> elements. It helps to add a text description for screen reader users. If there are decorative images, you can havealt="". More about decorative images here. -
Setting
font-size: 62.5%on html is... .... a hot controversial topic and non-standard 😅. There's been a lot of debate about this recently on Twitter 🙈. Be careful when using this in team projects because a lot of developers are very used to working with 16px base font size, you may incur a lot of unnecessary wrath.
Happy coding~ 😊
@Kerraan
Posted
@Milleus Thanks for replying! About point 3: Thanks for letting me know, i didnt know that. This is what i learned in a Udemy course. The thing i like about is, is the easy translation to "rem". So most developers use some kind of cheatsheet when tranlating px to rem?
Thanks again :)
@Kerraan I'd say a handful of developers are very used to working with "16px" as the base so translating to rem comes very naturally to them. For the weirder numbers, quick calculations can be done with the mac spotlight or calculator app.
More commonly for projects that use SCSS or SASS, there are usually (mixin or functions)[https://dev.to/nikolab/convert-px-to-rem-using- sass-3-methods-4ep2] that help to translate px to rem.
If you're using Vscode, there are also extensions that can help to convert px to rem.
I'd suggest searching "62.5%" in the Frontend Mentor slack community, there are many experienced developers that have shared their thoughts on this :)
Marked as helpful
