Skip to content
Submitted over 3 years ago

QR-code component

GSD3v08•190
@GSD3v08
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hello , this is my second project, could you tell me if there's something that can be improved or what should I learn for future projects?.

Feel free to leave your comments, any help will be appreciate it.

Thank you.

Code

Please log in to post a comment

Log in

Community feedback

  • Hyun Lee•140
    @Sagameister

    Looks, fantastic! The only tiny improvement I can see is in the HTML mark up you can make it more accessible like so:

    1. Consider rewrite <main> to <main class="card"></main> and remove <div class="card">. You also save 2 lines. ;-)
    2. Consider changing <div class="text-container"> to <article class="text-container">...

    By the way, I love the way you used the CSS variables. I need to do more of that.

    Cheers. 😃

    Marked as helpful
  • MatiX•360
    @MatiX221

    Really good. You should have at least one h1 tag. You can change <p class="qr-title">Improve your front-end skills by building projects</p> into <h1 class="qr-title">Improve your front-end skills by building projects</h1> And this accessibility issue will disapear.

    Marked as helpful
  • Bohdan•130
    @BohdanNikolaychuk

    Looks,incredibly.Never mind about this errors

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord