QR-Code Component using CSS Flexbox

Solution retrospective
This is my Solution of the QR-Code Component Challenge. I am happy for every Feedback .
Please log in to post a comment
Log in with GitHubCommunity feedback
- @CryptoPawn
Hey, great job on completing this challenge. The solution looks very good!
- It seems like you forgot to add a drop shadow to your card. Try adding
filter: drop-shadow()
with parameters to your card. You can check out the docs for this here. - To optimize SEO, study semantic elements. In this challenge solution you could, for example, replace
<div class="container">
with<section class="container">
and wrapping its content in an<article>
element. - You have applied the same color value on different classes in your CSS code. I'd recommend you trying out variables. Example:
:root { --magenta: hsl(300, 43%, 22%); } p { color: var(--magenta); }
On a more positive note, your code is well structured, clean and easy to read. Hope you appreciate the feedback and I'd love to see more challenge solutions from you! Keep up the great work. :)
Marked as helpful - It seems like you forgot to add a drop shadow to your card. Try adding
- @shashreesamuel
Hey good job completing this challenge
keep up the good work
Your solution looks great however I think that the font family of the card does not match the one specified in the
style-guide.md
file.I hope this helps
Cheers Happy coding 👍
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord