Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Code Component, w/ Flexbox

kelvin 160

@devenyam

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedback is welcome.

Community feedback

ROCKY BARUA 1,090

@Drougnov

Posted

Hello @devenyam, great job. The design looks pretty good.

However, you can improve on the responsiveness part(especially on laptop devices).

  • Use max-width: 320px(any size) instead of width. It will look more flexible. You'll not even need a media query then.

  • There are some accessibility issues on the Html part. Use main, footer, section etc. instead of div. And use at least one h1 tag on the page. You can change the h2 to h1.

Overall, great design. Keep it up. Have a good day my friend :)

Marked as helpful

0

kelvin 160

@devenyam

Posted

@Drougnov, thanks a lot for your feedback, it's really helpful👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord