Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

QR-Code CSS/HTML

accessibility, web-components
Sarah Cooper•30
@SarahCooper-TC
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Can you use Display: block instead of Display: flex for this?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055
    Posted over 1 year ago

    Hello Coder 👋

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    • Use min-height:100vh instead of height:100vh To dynamically center the card
    body{  
        display: flex;
        justify-content: center;
       align-items: center;
       min-height: 100vh;
       ...
    }
    
    • Use Semantics for the proper design of your code.
    <body>
    <main>... main content goes here ...</main>
    <footer>... .attribution div goes here ... </footer>
    </body>
    
    • For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".

    • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
  • Ryoshi1001•140
    @Ryoshi1001
    Posted over 1 year ago

    Hope can be good webpage made looks very good and almost same as design . @nehalSahu8055 added many good things that you can add if needed and gives better control of the page. Already have disply:flex for body of html that is needed to center the qr card in the middle of screen unless made new div/section/main element than used that for centering. A main div would be good that way you can put the attribute at the bottom of the webpage.

    If question is about display block instead of flex for the .box class name you made than you can erase flex from it since everything in the qr card are block elements and use padding to make it look ok I changed a few things in your css and html for you to also try hope this helps thank you take care gn gm frens body { height: 100vh; display: flex; flex-direction: column; justify-content: center; align-items: center; background-color: hsl(205, 73%, 88%); }

    .box { width:288px; height: auto; padding: 14px; text-align: center; border-radius: 20px; background-color: hsl(0, 0%, 100%); }

    img { width: 288px; height: 288px; border-radius: 10px; }

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub