Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

QR-code. HTML and CSS

P
Kaczupinko•170
@Kaczupinko
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm most proud of writing clear, maintainable code with correct semantic structure. This not only ensures that the code is easy to understand and work with but also improves accessibility and search engine optimization. If I were to do anything differently next time, I would focus on optimizing the code further for performance, such as by reducing the file sizes of images and other assets, or by leveraging more advanced CSS techniques to enhance responsiveness across different devices.

What challenges did you encounter, and how did you overcome them?

I initially encountered challenges with the layout breaking when starting from the smallest elements. To address this, I decided to take a break and then systematically rework the layout step by step. This approach allowed me to better structure the elements and maintain the overall design integrity, ensuring that each part of the project fit together as intended. This methodical process helped me overcome the initial difficulties and achieve a more polished final result.

What specific areas of your project would you like help with?

The project was small, so I didn't notice any specific areas that needed particular attention. However, any feedback, no matter how minor, would be greatly appreciated and valued.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Sachin•830
    @Sachin-Mahato
    Posted about 2 years ago

    Well done for completing the challenge


    .Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.


    1. Lack of semantic HTML:

    • Semantic HTML elements are missing or not used appropriately.
    • The structure does not convey the meaning and purpose of different parts of the webpage.

    -.Every site should ALWAYS have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serve as the component’s container

    --

    More info


    .Avoid skipping heading levels ⚠️.

    • Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the heading’s level of importance.

    More info


    2. Usage of absolute units instead of relative units:

    • Absolute units like pixels (px) are used for defining lengths and sizes instead of relative units like percentages (%), em, or rem.
    • Relative units are more flexible and responsive across different screen sizes.

    More info


    For improved accessibility 📈 for your content, it is best practice to use em ✅ for media queries. Using this unit gives users the ability to scale elements up and down, relative to a set value use this link to learn about media queries


    more info


    I hope you find this helpful and happy coding

    Marked as helpful
  • Abdallah Aminu Daneji•240
    @waad2lf
    Posted about 2 years ago

    Wow, Nice work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub