Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

qr-code made with HTML & CSS

Marco Tsang•50
@hkmarcoot
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I find difficult centring containers horizontally and vertically.

I am unsure how to put the attribution back to the bottom since it going to the top automatically.

Overall, it is a rather simple task when working with my friend Luis in pair programming.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted over 2 years ago

    Hi @hkmarcoot 👋, good job completing this challenge! 🎉

    I have some suggestions you might consider to improve your code:

    • Use the <main> tag to wrap all the main content in your solution instead of using <div class="all-container">.
    • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.
    • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.
    • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
    • Centering the element with position would make your element behave strangely on some mobile devices. There are two modern CSS techniques to center elements:

    Using flexbox layout:

    body {
       min-height: 100vh;
       display: flex;
       flex-direction: column;
       justify-content: center;
       align-items: center;
    }
    

    Using grid layout:

    body {
       min-height: 100vh;
       display: grid;
       place-content: center;
    }
    

    Links with more information:

    • The Complete Guide to Centering in CSS.
    • A Complete Guide to Flexbox (CSS-Tricks).
    • How TO - Center Elements Vertically (W3Schools).
    • CSS Layout - Horizontal & Vertical Align (W3Schools).

    Above all, the project is done well👏. I hope those tips will help you! 👍

    Good job, and happy coding! 😁

    Marked as helpful
  • Adriano•42,890
    @AdrianoEscarabote
    Posted over 2 years ago

    Hi Marco Tsang, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    As you know this project is based only on one page component, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

    Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

    if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

    The rest is great!

    I hope it helps... 👍

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub