Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Qr-code my Solution

ElijahPoblete•20
@ElijahPoblete
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


i find looking for the background of the image difficult i think. I am unsure of its reponsiveness. I also think that i have a disorganized code. Please give me some advice about how i structure my code. I'm still new to coding so i would be happy for for every criticism and advices thank you!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jose Antonio González Santos•90
    @devpullcode
    Posted over 1 year ago

    "I've been reviewing your code, and you're on the right track. 👏

    Below, I'll give you some recommendations, but don't worry about making the code perfect. The important thing at the beginning is to discover and learn new techniques without worrying too much about optimization.

    1. I recommend formatting your code properly. You can use a formatter like Prettier in VSC (Visual Studio Code). 🧹

    2. Avoid creating too many <div> elements and look for HTML elements that can represent the blocks you're creating. Instead of using the <div class="caption"> tag, you can use the <figcaption> tag along with the <figure> tag, which associates an image with its description. Look into the concept of HTML semantics!

    3. While you're starting out, focus on simplifying the design and don't try to add too many HTML elements to make it easier to write CSS. I'm referring to the hyperlinks you added to the text; they weren't necessary, but they're good for practice.

    4. Another recommendation, not directly related to the project itself, is to avoid using fixed heights. I recommend that the height of the element is calculated based on its children; it will make your design work easier. I've also used a fixed height 😄, but I recommend not using them.

    5. Use comments to understand what the code is doing so that when you come back to it in the future, you'll have an easier time grasping it. Over time, as you advance in your learning, you'll need them less and less.

    6. In this practice, it's not necessary to use media queries because the design adapts well to all devices. So avoid making unnecessary modifications if they're not needed. It will make your life easier! 😜

    7. Try to group each content into its corresponding directories/folders. I'm referring to the two screenshots; you can place them inside the 'images' directory and create another subdirectory in there if needed.

    Other than that, congratulations on your project, and kudos for embarking on this wonderful journey into the world of programming. Keep it up, and you'll go far. Go for it! 🚀👨‍💻"

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub